Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7674: Skip redirection to user profile if user CT is edited via configuration view #1143

Merged
merged 3 commits into from
Jan 31, 2024

Conversation

konradoboza
Copy link
Contributor

Question Answer
JIRA issue IBX-7674
Type bug
Target version v4.6
BC breaks no
Doc needed no

It seems that if User (besides default Editor) CT was enabled to have "User profile" feature, the redirection was a bit imprecise. UserProfileListener now detects if it was triggered from dedicated view. Therefore. if "User" CT is edited in the configuration view of BO, we are not redirected (we basically stay in the same view, as it was before introducing user profiles).

Besides UserProfileListener is already automatically registered, so I removed explicit YAML configuration entry.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@konradoboza konradoboza added Bug Something isn't working Ready for review labels Jan 31, 2024
@konradoboza konradoboza self-assigned this Jan 31, 2024
@konradoboza konradoboza requested a review from a team January 31, 2024 11:26
@konradoboza konradoboza requested review from a team and Steveb-p January 31, 2024 11:48
@konradoboza konradoboza requested a review from Steveb-p January 31, 2024 14:17
@konradoboza konradoboza force-pushed the ibx-7674-wrong-redirect-on-user-editing branch from 6c5823e to 5c30f6d Compare January 31, 2024 14:20
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@konradoboza konradoboza merged commit b49bd7e into main Jan 31, 2024
22 checks passed
@konradoboza konradoboza deleted the ibx-7674-wrong-redirect-on-user-editing branch January 31, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working QA approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants