Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7773: Fix Sub-items sorting order form vertical alignment #1167

Merged
merged 3 commits into from
Feb 13, 2024

Conversation

tischsoic
Copy link
Contributor

@tischsoic tischsoic commented Feb 13, 2024

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-7773
Type bug
Target version v4.6
BC breaks no
Doc needed no

After alignment:
Screenshot 2024-02-13 at 10 17 22

Also fix for:
Screenshot 2024-02-13 at 10 19 37

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@lserwatka
Copy link
Contributor

lserwatka commented Feb 13, 2024

But is size correct? Shouldn't we have it smaller like other Select lists above? This is a bit unbalanced.

@tischsoic
Copy link
Contributor Author

@lserwatka, I think this is a good idea. ping @IdaDra @Ingu12 .

@lserwatka
Copy link
Contributor

Another problem I see here. Why this is part of Technical Details? Now, when we have Sub-items tab it should be part of it. Why this was not taken into account during design phase? @NataliaBecla

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tischsoic
Copy link
Contributor Author

@lserwatka I fixed the UI to match the new design. This design was prepared by the design team before I started work on this bug, but since I knew only about bad alignment I didn't realise that the new design was prepared for this part of the UI.

The new UI:
Screenshot 2024-02-13 at 10 22 33

@@ -203,6 +203,10 @@
font-weight: 400;
line-height: calculateRem(18px);
padding: calculateRem(12px) calculateRem(16px) 0;

&:empty {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we do not want list header to take space when it is empty

@IdaDra
Copy link

IdaDra commented Feb 13, 2024

Another problem I see here. Why this is part of Technical Details? Now, when we have Sub-items tab it should be part of it. Why this was not taken into account during design phase? @NataliaBecla

We were discussing it during discovery phase and decided not to change that in this release. Sorting is another big thing to change is whole system, this setting is local (refers to exact element in tree) and change require rethink whole behaviour. We are aware of it and we're working on improving sorting and filtering in Ibexa in next releases.

@ViniTou ViniTou merged commit 526fc99 into main Feb 13, 2024
23 checks passed
@ViniTou ViniTou deleted the IBX-7773-sorting-order-items-not-centered branch February 13, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.