-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-7773: Fix Sub-items sorting order form vertical alignment #1167
Conversation
But is size correct? Shouldn't we have it smaller like other Select lists above? This is a bit unbalanced. |
@lserwatka, I think this is a good idea. ping @IdaDra @Ingu12 . |
Another problem I see here. Why this is part of Technical Details? Now, when we have Sub-items tab it should be part of it. Why this was not taken into account during design phase? @NataliaBecla |
Quality Gate passedIssues Measures |
@lserwatka I fixed the UI to match the new design. This design was prepared by the design team before I started work on this bug, but since I knew only about bad alignment I didn't realise that the new design was prepared for this part of the UI. |
@@ -203,6 +203,10 @@ | |||
font-weight: 400; | |||
line-height: calculateRem(18px); | |||
padding: calculateRem(12px) calculateRem(16px) 0; | |||
|
|||
&:empty { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: we do not want list header to take space when it is empty
We were discussing it during discovery phase and decided not to change that in this release. Sorting is another big thing to change is whole system, this setting is local (refers to exact element in tree) and change require rethink whole behaviour. We are aware of it and we're working on improving sorting and filtering in Ibexa in next releases. |
v4.6
After alignment:
Also fix for:
Checklist:
@ibexa/engineering
).