Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-7677: Remove markedLocationId reset to null from useSearchByQueryFetch #1172

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

tischsoic
Copy link
Contributor

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-7677
Type bug
Target version v4.6
BC breaks no
Doc needed no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@@ -41,7 +40,6 @@ export const useSearchByQueryFetch = () => {
contentNameCriterion = null,
) => {
const handleFetch = (response) => {
setMarkedLocationId(null);
Copy link
Contributor Author

@tischsoic tischsoic Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: we do not want to reset the marked location id with every search, so I moved it to a more specific place. (changes are related to changes from: #420)

@tischsoic tischsoic force-pushed the IBX-7677-starting-location-id branch from f4761c1 to 9f3300f Compare February 14, 2024 13:52
@tischsoic tischsoic force-pushed the IBX-7677-starting-location-id branch from 9f3300f to ef1b823 Compare February 14, 2024 14:50
@tomaszszopinski tomaszszopinski self-assigned this Feb 15, 2024
@tischsoic tischsoic force-pushed the IBX-7677-starting-location-id branch from ef1b823 to 27810b7 Compare February 15, 2024 07:17
@tischsoic tischsoic force-pushed the IBX-7677-starting-location-id branch from 27810b7 to a2c6b74 Compare February 15, 2024 11:49
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.6 commerce.

@ViniTou ViniTou merged commit b4b49bd into main Feb 15, 2024
22 checks passed
@ViniTou ViniTou deleted the IBX-7677-starting-location-id branch February 15, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants