IBX-7030: [UDW] Inactive edit button in grid view #1175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabowskiM
force-pushed
the
IBX-7030-udw-grid-view
branch
from
d2a0770 to
9f5dc7e
Compare
lucasOsti
approved these changes
Feb 20, 2024
dew326
approved these changes
Feb 20, 2024
Gengar-i
approved these changes
Feb 21, 2024
GrabowskiM
force-pushed
the
IBX-7030-udw-grid-view
branch
from
9f5dc7e to
52d8f58
Compare
katarzynazawada
requested changes
Mar 7, 2024
GrabowskiM
force-pushed
the
IBX-7030-udw-grid-view
branch
from
28794d0 to
ee1e821
Compare
lucasOsti
approved these changes
Mar 13, 2024
dew326
approved these changes
Mar 13, 2024
Gengar-i
approved these changes
Mar 14, 2024
tischsoic
reviewed
Mar 14, 2024
| import { getTranslator } from '@ibexa-admin-ui/src/bundle/Resources/public/js/scripts/helpers/context.helper'; | ||
|
|
||
| const getLoadedLocationsLimitedMap = (loadedLocationsFullMap, activeLocationId) => { |
There was a problem hiding this comment.
Why is it placed outside of the component? 🤔
| const getLoadedLocationsLimitedMap = (loadedLocationsFullMap, activeLocationId) => { | ||
| const itemIndex = loadedLocationsFullMap.findIndex(({ parentLocationId }) => parentLocationId === activeLocationId); | ||
|
|
||
| return loadedLocationsFullMap.slice(0, itemIndex + 1); |
There was a problem hiding this comment.
Shouldn't we check whether itemIndex is different from -1?
GrabowskiM
force-pushed
the
IBX-7030-udw-grid-view
branch
from
db58d01 to
da117be
Compare
|
tischsoic
approved these changes
Mar 18, 2024
katarzynazawada
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.6For whole UDW markedLocationId is used as both item that is detailed in sidebar and parent of last/active branch.
It changes however in grid view, where markedLocationId keeps data about details in sidebar, but it's not necessary parent of visible items, therefore I've added extra state variable
gridActiveLocationIdthat is used only in grid view and keeps info about parent of visible subitems.At first I wanted to keep it only in GridView component, but I had to move it to the top, as entering CotF destroyes everything except top layer, so state for activeLocationId was lost as well and we need this info after closing CotF.
Checklist:
@ibexa/engineering).