Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7209: Clear results button in UDW Search #1188

Merged
merged 7 commits into from
Feb 27, 2024
Merged

IBX-7209: Clear results button in UDW Search #1188

merged 7 commits into from
Feb 27, 2024

Conversation

tischsoic
Copy link
Contributor

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-7209
Type bug
Target version v4.6
BC breaks no
Doc needed no

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@tischsoic tischsoic self-assigned this Feb 22, 2024
@tischsoic tischsoic marked this pull request as ready for review February 22, 2024 07:58
@tischsoic tischsoic requested a review from lucasOsti February 22, 2024 08:10
@barbaragr barbaragr self-assigned this Feb 23, 2024
barbaragr
barbaragr requested changes Feb 26, 2024
View reviewed changes
Copy link

@barbaragr barbaragr left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicked/active state for Clear results button - outline is incomplete for Chrome, for Safari there is no outline at all:
Screenshot 2024-02-26 at 09 45 55

Clears result doesn't clear search input:
https://github.com/ibexa/admin-ui/assets/32538832/c7f3855b-eaf3-4b2c-b5ca-0c2ba764afa1

@tischsoic tischsoic requested a review from barbaragr February 27, 2024 08:03
@tischsoic tischsoic force-pushed the IBX-7209-udw-search-clear-results-btn branch from 7b798ef to 62c99e5 Compare February 27, 2024 09:03
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dew326 dew326 merged commit cfb5897 into main Feb 27, 2024
22 checks passed
@dew326 dew326 deleted the IBX-7209-udw-search-clear-results-btn branch February 27, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gengar-i Gengar-i Gengar-i approved these changes

@barbaragr barbaragr barbaragr approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@ViniTou ViniTou ViniTou approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@tischsoic tischsoic

@dew326 dew326

@ViniTou ViniTou

@barbaragr barbaragr

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tischsoic @mikadamczyk @GrabowskiM @dew326 @ViniTou @lucasOsti @barbaragr @Gengar-i @Nattfarinn @ciastektk