IBX-1608: Added possibility to add field by click #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
changed the title
lucasOsti
approved these changes
Dec 21, 2021
tischsoic
requested changes
Dec 21, 2021
| @@ -60,6 +60,11 @@ | |||
| } | |||
| } | |||
|
|
|||
| &--active-field-definitions-group { | |||
| border: calculateRem(1px) solid $ibexa-color-info; | |||
| border-radius: $ibexa-border-radius; | |||
There was a problem hiding this comment.
Question: Shouldn't border-radius be defined directly on element? That border does not add to element width?
| ); | ||
|
|
||
| if (targetContainer) { | ||
| addField(event.currentTarget); |
There was a problem hiding this comment.
Suggested change
| addField(event.currentTarget); | |
| addField(); |
| '.ibexa-collapse--field-definitions-group.ibexa-collapse--active-field-definitions-group .ibexa-content-type-edit__field-definition-drop-zone' | ||
| ); | ||
|
|
||
| if (targetContainer) { |
There was a problem hiding this comment.
nitpick: probably we can add this check at the beginning and then proceed with preparing data for addField.
tischsoic
approved these changes
Dec 21, 2021
dew326
force-pushed
the
drop-after-click
branch
from
ddb4a14 to
f4748f3
Compare
GrabowskiM
approved these changes
Dec 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)