IBX-8837: Distraction free mode: Text obstruction by toolbar's fixed position #1361
Conversation
|
| @@ -16,6 +17,43 @@ | |||
| activeFieldEdit.classList.toggle('ibexa-field-edit--distraction-free-mode-active', active); | |||
| editorInstance.set('distractionFreeModeActive', active); | |||
|
|
|||
| if (active) { | |||
There was a problem hiding this comment.
Should we safeguard the possibility of calling changeDistractionFreeModeState two times in a row with the same active parameter value by e.g. checking whether clearedPositionNodesData is not empty?
There was a problem hiding this comment.
I have analyzed this part, and I think it's more foolproof is without any extra condition, as it will assure correct placement on each run - so it's immune to changing positions/overflow below when distraction free mode is on.
The only "problem" is that it has to traverse whole DOM tree on rerunning it with true, but I think it's small price to pay.
| if (active) { | ||
| let parentElement = activeFieldEdit.parentNode; | ||
|
|
||
| while (parentElement && parentElement !== doc.body) { |
There was a problem hiding this comment.
I think this new fragment may be more readable if split into two functions e.g. resetAncestorsPositions(), restoreAncestorsPositions()
There was a problem hiding this comment.
OK, Besides Kuba's comment https://github.com/ibexa/admin-ui/pull/1361/files#r1806371839 which I agree with :)
|
Description:
This bug is caused by CKEditor code itself, I've created issue there ckeditor/ckeditor5#17241 but I doubt it will be resolved soon (if ever), judging from my experience, so here's fix for it.
I'm basically temporarly removing styles that breaks supossed correct behaviour, as distraction free mode takes whole page, it doesn't matter what happens beneath, as it's not visible. When closing DFM I restore remove my inline styles/restore previous inline styles
For QA:
This solves https://issues.ibexa.co/browse/IBX-8965 as well, I think.
Documentation: