IBX-9008: Added language helper #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bozatko
approved these changes
Oct 16, 2024
tischsoic
reviewed
Oct 16, 2024
| @@ -0,0 +1,5 @@ | |||
| const getLanguageCode = () => { | |||
| return window.document.querySelector('meta[name="LanguageCode"]')?.content; | |||
There was a problem hiding this comment.
Should we consider using ibexa.adminUiConfig.backOfficeLanguage as a fallback, similarly to the getId function in the user helper?
(on second thought this suggestion does not make much sense, but my mistake suggests that the naming of the helper function is not precise enough)
There was a problem hiding this comment.
This probably should be content helper.
|
bozatko
approved these changes
Oct 17, 2024
adamwojs
approved these changes
Oct 17, 2024
dew326
approved these changes
Oct 17, 2024
lucasOsti
approved these changes
Oct 17, 2024
tischsoic
approved these changes
Oct 18, 2024
tomaszszopinski
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: