Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-8714: Add languageCode to the v2/views request #1375

Merged
merged 4 commits into from
Nov 5, 2024

Conversation

tischsoic
Copy link
Contributor

@tischsoic tischsoic commented Oct 18, 2024

🎫 Issue IBX-8714

Related PRs:

Description:

For QA:

DXP and standalone app need tests

Documentation:

@tischsoic tischsoic self-assigned this Oct 18, 2024
@tischsoic tischsoic changed the base branch from main to 4.6 October 18, 2024 08:04
Copy link
Member

@adamwojs adamwojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please double check with @lucasOsti, that changed will not break ibexa/dam in standalone mode.

@lucasOsti
Copy link
Contributor

Please double check with @lucasOsti, that changed will not break ibexa/dam in standalone mode.

I checked it, It's look like will be fine

@KamilSznajdrowicz KamilSznajdrowicz force-pushed the IBX-8714-UDW-slowed-down-by-big-fields-request branch from 0a713ca to 5fc2ae3 Compare November 5, 2024 12:02
Copy link

sonarqubecloud bot commented Nov 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
30.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@dew326 dew326 merged commit 1a90d69 into 4.6 Nov 5, 2024
27 of 28 checks passed
@dew326 dew326 deleted the IBX-8714-UDW-slowed-down-by-big-fields-request branch November 5, 2024 13:38
@tischsoic
Copy link
Contributor Author

Merged up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants