IBX-9143: Fixed middle ellipsis overlapping text #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bozatko
approved these changes
Oct 30, 2024
lucasOsti
approved these changes
Oct 30, 2024
KamilSznajdrowicz
requested changes
Nov 8, 2024
There was a problem hiding this comment.
Small bug here
According to the design notes, we should not truncate by half a character for longer texts. Please revise the adjustment so that truncation occurs at a minimum of one full character.
Update: After discussion reported in another task https://issues.ibexa.co/browse/IBX-9241
KamilSznajdrowicz
approved these changes
Nov 20, 2024
GrabowskiM
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For QA:
Documentation: