IBX-1588: add location helper; fix ibexa-input--checkbox input, ibexa-tag #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tischsoic
commented
Dec 29, 2021
tischsoic
commented
| Question | Answer |
|---|---|
| Tickets | https://issues.ibexa.co/browse/IBX-1588 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Tests pass? | yes |
| Doc needed? | yes |
| License | GPL-2.0 |
…path select in Personalization) Fix checkbox/radiobox alignment
dew326
requested changes
Dec 29, 2021
src/bundle/Resources/public/js/scripts/helpers/location.helper.js
Outdated
Show resolved
Hide resolved
tischsoic
commented
Dec 29, 2021
| @@ -113,8 +113,6 @@ | |||
| appearance: none; | |||
| position: relative; | |||
| display: inline-block; | |||
| vertical-align: middle; | |||
There was a problem hiding this comment.
Note: deleted because middle alignment does not work with multiline labels (checkbox should be aligned with the top line):
| before | after |
|---|---|
 |
 |
dew326
approved these changes
Dec 29, 2021
lucasOsti
approved these changes
Dec 29, 2021
GrabowskiM
approved these changes
Jan 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.