Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-1776: Removed "Change password" item from user menu #164

Merged
merged 2 commits into from
Jan 11, 2022
Merged

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Jan 4, 2022

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-1776
Bug fix? no
New feature? no
BC breaks? YES
Tests pass? yes
Doc needed? yes
License GPL-2.0

Checklist:

  • Update Behats
  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@adamwojs adamwojs added the Doc needed The changes require some documentation label Jan 4, 2022
@micszo micszo self-assigned this Jan 10, 2022
@micszo
Copy link
Contributor

micszo commented Jan 10, 2022

@mnocon please have a look at edf8306.

@mnocon
Copy link
Contributor

mnocon commented Jan 10, 2022

We should also remove the step that's no longer valid:

/**
* @Given I go to change my password
* @Given I go to change my password in user preferences
*/
public function iGoToChangeMyPassword()
{
$this->upperMenu->chooseFromUserDropdown('Change password');
}

@adamwojs adamwojs requested a review from a team January 11, 2022 09:52
@Steveb-p Steveb-p requested a review from a team January 11, 2022 10:32
@adamwojs adamwojs merged commit e6a30ff into main Jan 11, 2022
@adamwojs adamwojs deleted the ibx_1776 branch January 11, 2022 10:48
@DominikaK DominikaK removed the Doc needed The changes require some documentation label Feb 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants