IBX-1526: change edit fields width to full column; Page Builder updates #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tischsoic
commented
Jan 11, 2022
tischsoic
commented
| Question | Answer |
|---|---|
| Tickets | https://issues.ibexa.co/browse/IBX-1526 |
| Bug fix? | yes/no |
| New feature? | no |
| BC breaks? | no |
| Tests pass? | yes |
| Doc needed? | no |
| License | GPL-2.0 |
GrabowskiM
reviewed
Jan 11, 2022
| @@ -62,7 +62,7 @@ | |||
| </div> | |||
| {% else %} | |||
| <div class="row"> | |||
| <div class="offset-1 col-6 p-0"> | |||
| {% if not is_full_width|default(false) %}<div class="offset-1 col-6 p-0">{% endif %} | |||
There was a problem hiding this comment.
Are you sure we want to complemtely remove this div? Instead of adding class col-12 or sth like this?
There was a problem hiding this comment.
Yeah, on the second thought I think it may be better to only change CSS classes.
dew326
reviewed
Jan 11, 2022
| @@ -62,7 +62,9 @@ | |||
| </div> | |||
| {% else %} | |||
| <div class="row"> | |||
| <div class="offset-1 col-6 p-0"> | |||
| <div class=" | |||
| {{ is_full_width|default(false) ? 'col-12' : 'col-6 offset-1 p-0' }}" | |||
lucasOsti
reviewed
Jan 11, 2022
| @@ -62,7 +62,7 @@ | |||
| </div> | |||
| {% else %} | |||
| <div class="row"> | |||
| <div class="offset-1 col-6 p-0"> | |||
| <div class="{{ is_full_width|default(false) ? 'col-12' : 'col-6 offset-1 p-0' }}"> | |||
There was a problem hiding this comment.
I know it's not yours but could we not use the class p-0 and the like because later there are more problems than good
lucasOsti
approved these changes
Jan 12, 2022
dew326
approved these changes
Jan 12, 2022
GrabowskiM
approved these changes
Jan 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.