Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2557: Fix badge #367

Merged
merged 5 commits into from
Apr 27, 2022
Merged

IBX-2557: Fix badge #367

merged 5 commits into from
Apr 27, 2022

Conversation

tischsoic
Copy link
Contributor

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-2557
Bug fix? yes/no
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

Related PRs:

@tischsoic tischsoic self-assigned this Mar 17, 2022
lucasOsti
lucasOsti reviewed Mar 31, 2022
View reviewed changes
src/bundle/Resources/public/scss/_badges.scss
line-height: calculateRem(16px);
font-weight: normal;
border: calculateRem(1px) solid $ibexa-color-dark;
border-radius: calculateRem(12px);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new 12px value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same case as in dropdown which partly shares design :)
#383 (comment)

@tischsoic tischsoic force-pushed the IBX-2557-fix-badges branch from dd444c8 to aa4ab84 Compare March 31, 2022 13:50
@tischsoic tischsoic force-pushed the IBX-2557-fix-badges branch from 7eb821a to 9a73a10 Compare April 25, 2022 11:49
@tischsoic tischsoic changed the base branch from main to 4.1 April 25, 2022 11:49
@bogusez bogusez assigned bogusez and unassigned bogusez Apr 25, 2022
This was referenced Apr 26, 2022
Closed
Closed
Closed
@bogusez bogusez mentioned this pull request Apr 26, 2022
Closed
@bogusez
Copy link
Contributor

bogusez commented Apr 27, 2022

Regression tests Passed: ibexa/commerce#71

@dew326 dew326 merged commit edf805d into 4.1 Apr 27, 2022
@dew326 dew326 deleted the IBX-2557-fix-badges branch April 27, 2022 09:30
@tischsoic
Copy link
Contributor Author

Merged up:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@dew326 dew326 dew326 approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

Assignees

@tischsoic tischsoic

@dew326 dew326

@bogusez bogusez

Labels
QA approved Ready for MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tischsoic @bogusez @GrabowskiM @dew326 @lucasOsti