IBX-2655: create/edit layout fixes #391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
reviewed
Apr 8, 2022
| @@ -1,3 +1,11 @@ | |||
| .ibexa-edit-content { | |||
| @include edit-right-side-container; | |||
|
|
|||
| &__fulfillment { | |||
There was a problem hiding this comment.
I'm not sure about this name
lucasOsti
force-pushed
the
IBX-2655-create-edit-layout-fixes
branch
from
8a58351 to
445549c
Compare
GrabowskiM
reviewed
Apr 25, 2022
| @@ -4,6 +4,7 @@ | |||
|
|
|||
| {% set grouped_fields = grouped_fields|default([]) %} | |||
| {% set anchor_params = { items: grouped_fields|keys } %} | |||
|
|
|||
dew326
approved these changes
Apr 26, 2022
GrabowskiM
approved these changes
Apr 27, 2022
tischsoic
approved these changes
Apr 27, 2022
| @@ -1,17 +1,22 @@ | |||
| {% extends '@ibexadesign/ui/edit_section.html.twig' %} | |||
|
|
|||
| {% set attr = { class: 'ibexa-content-type-edit__section' } %} | |||
| {% set one_column_layout = one_column_layout|default(false) %} | |||
There was a problem hiding this comment.
Suggested change
| {% set one_column_layout = one_column_layout|default(false) %} | |
| {% set is_one_column_layout = is_one_column_layout|default(false) %} |
lucasOsti
force-pushed
the
IBX-2655-create-edit-layout-fixes
branch
from
5810685 to
fb8ac43
Compare
lucasOsti
force-pushed
the
IBX-2655-create-edit-layout-fixes
branch
from
c81d16f to
d00832d
Compare
lucasOsti
requested review from
tischsoic,
dew326 and
GrabowskiM
and removed request for
GrabowskiM
tischsoic
approved these changes
May 5, 2022
GrabowskiM
approved these changes
May 5, 2022
katarzynazawada
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed create/edit layout by removing boostrap class
rowandcol-. All content should be aligned to the left sidebar1376px width
1920px width
Checklist:
$ composer fix-cs)