Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-3092: dropdown in subfield should be small like other fields #479

Merged
merged 2 commits into from
Jun 28, 2022
Merged

IBX-3092: dropdown in subfield should be small like other fields #479

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40871bb
IBX-3092: Dropdown in subfields should have small size
tischsoic Jun 25, 2022
4bf59cb
Do not render ibexa-form-error when form is valid
tischsoic Jun 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/bundle/Resources/views/themes/admin/content/form_fields.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,10 @@

{% set label_attr = label_attr|merge({'class': (label_attr.class|default('') ~ ' ibexa-label ibexa-data-source__label ibexa-data-source__label')|trim}) %}
{% set label_wrapper_attr = label_wrapper_attr|default({})|merge({'class': (label_wrapper_attr.class|default('') ~ ' ibexa-data-source__label-wrapper ibexa-data-source__label-wrapper')|trim}) %}
{% set attr = attr|merge({'class': (attr.class|default('') ~ ' ibexa-data-source__input ibexa-data-source__input ibexa-input--small')|trim}) %}
{% set attr = attr|merge({
class: (attr.class|default('') ~ ' ibexa-data-source__input ibexa-data-source__input ibexa-input--small')|trim,
is_small: true,
Copy link
Contributor Author

@tischsoic tischsoic Jun 25, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like passing this in attr because we usually use attr as HTML element params, but this is how it is currently done in the dropdown widget:

admin-ui/src/bundle/Resources/views/themes/admin/ui/form_fields/dropdown_widget.html.twig

Line 25 in 034e145

is_small: attr.is_small|default(false),

Another option would be to deprecate this approach and add a separate is_small variable.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you have other ideas?

}) %}
{% set wrapper_attr = wrapper_attr|default({})|merge({class: (wrapper_attr.class|default('') ~ ' ' ~ wrapper_class)|trim}) %}
{% set widget_wrapper_attr = widget_wrapper_attr|default({})|merge({class: (widget_wrapper_attr.class|default('') ~ ' ibexa-data-source__input-wrapper ibexa-data-source__input-wrapper')|trim}) %}

Expand Down