IBX-3242: Added twig macros for rendering form fields in edit base view #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tischsoic
commented
Jul 14, 2022
tischsoic
commented
| Question | Answer |
|---|---|
| Tickets | https://issues.ibexa.co/browse/IBX-3242 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Tests pass? | yes |
| Doc needed? | yes/no |
| License | GPL-2.0 |
tischsoic
commented
Jul 14, 2022
| } %} | ||
| {% trans_default_domain 'content_edit' %} | ||
| {% import parentSelf as parentSelf %} |
There was a problem hiding this comment.
Note: it seems that it needs to be done this way.
ref. twigphp/Twig#2442 (comment)
dew326
approved these changes
Jul 14, 2022
lucasOsti
reviewed
Jul 19, 2022
src/bundle/Resources/views/themes/admin/content/edit_base.html.twig
Outdated
Show resolved
Hide resolved
lucasOsti
approved these changes
Jul 20, 2022
GrabowskiM
approved these changes
Jul 20, 2022
mnocon
approved these changes
Jul 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.