IBX-3799: Change default value for headline_title in table #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tischsoic
approved these changes
Sep 13, 2022
GrabowskiM
approved these changes
Sep 15, 2022
lucasOsti
force-pushed
the
IBX-3799-Unnecessary-tooltip-for-table-header
branch
from
6c06947 to
7693992
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
katarzynazawada
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed the default value for the variable headline_title in the table component and the headline table. Previously, the default value was set as headline and if there is no headline, it was set to an empty string.
Currently default is always an empty string and the user must set the headline_title variable to have a tooltip because according to our design system, if we have a label somewhere, we should not have a tooltip
Checklist:
$ composer fix-cs)