IBX-3973: Nontranslatable and disabled fields are not greyed out in content editing UI #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrabowskiM
changed the title
GrabowskiM
requested review from
dew326,
tischsoic,
lucasOsti and
Gengar-i
and removed request for
dew326
GrabowskiM
force-pushed
the
IBX-3973-disabled-edit-form-fields
branch
from
4d5a3ec to
7abf88e
Compare
lucasOsti
approved these changes
Oct 24, 2022
dew326
approved these changes
Oct 24, 2022
Gengar-i
reviewed
Oct 27, 2022
| color: $ibexa-color-dark-300; | ||
|
|
||
| &::before, | ||
| &::after { |
There was a problem hiding this comment.
Before and after do not need content: '' anymore?
There was a problem hiding this comment.
content: '' was specified in the same file here:
here we only override
background-color.
tischsoic
approved these changes
Oct 27, 2022
|
|
||
| &__map { | ||
| z-index: 0; | ||
| width: 50%; | ||
| height: calculateRem(400px); | ||
| border-top-left-radius: $ibexa-border-radius; | ||
| border-bottom-left-radius: $ibexa-border-radius; | ||
| position: relative; | ||
|
|
||
| &--disabled::after { |
There was a problem hiding this comment.
nitpitck
Suggested change
| &--disabled::after { | |
| &--disabled { | |
| &::after { |
| @@ -143,7 +143,9 @@ | |||
| {%- if form.parent is empty -%} | |||
| {{ form_errors(form) }} | |||
| {%- endif -%} | |||
| {{- block('form_rows') -}} | |||
| {% with { attr: attr } %} | |||
There was a problem hiding this comment.
Suggested change
| {% with { attr: attr } %} | |
| {% with { attr } %} |
| {% set attr = attr|merge({'data-max-file-size': max_file_size}) %} | ||
| {% set wrapper_attr = wrapper_attr|default({})|merge({'class': (wrapper_attr.class|default('') ~ ' ibexa-field-edit--with-preview')|trim}) %} | ||
| {% set preview_attr = preview_attr|default({})|merge({'class': (preview_attr.class|default('') ~ ' ibexa-field-edit__preview')|trim}) %} | ||
| {% set widget_wrapper_attr = widget_wrapper_attr|default({})|merge({'class': (widget_wrapper_attr.class|default('') ~ ' ibexa-field-edit__data')|trim}) %} | ||
|
|
||
| {% if fieldtype_is_not_translatable or fieldtype.vars.disabled %} | ||
| {% set attr = attr|merge({'readonly': 'readonly'}) %} |
There was a problem hiding this comment.
Suggested change
| {% set attr = attr|merge({'readonly': 'readonly'}) %} | |
| {% set attr = attr|merge({ readonly: 'readonly' }) %} |
| @@ -37,21 +40,27 @@ | |||
| <label class="ibexa-label form-label">{{ 'ezauthor.Email'|trans|desc('Email') }}</label> | |||
| </div> | |||
| {% for child in form.authors %} | |||
| {{ form_row(child) }} | |||
| {{ form_row(child, { attr: { readonly: readonly}}) }} | |||
There was a problem hiding this comment.
Suggested change
| {{ form_row(child, { attr: { readonly: readonly}}) }} | |
| {{ form_row(child, { attr: { readonly }}) }} |
|
Form field is still not greyed out |
Gengar-i
approved these changes
Nov 14, 2022
GrabowskiM
force-pushed
the
IBX-3973-disabled-edit-form-fields
branch
from
7abf88e to
0301a7b
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
Form field will be fixed as follow-up |
katarzynazawada
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)