IBX-5138: The header in content edit view is displayed incorrectly when scrolling #714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasOsti
approved these changes
Feb 27, 2023
dew326
approved these changes
Feb 27, 2023
tischsoic
reviewed
Feb 27, 2023
| @@ -23,6 +35,10 @@ | |||
| const shouldHeaderBeSlim = scrollTop > SCROLL_POSITION_TO_FIT; | |||
|
|
|||
| headerNode.classList.toggle('ibexa-edit-header--slim', shouldHeaderBeSlim); | |||
|
|
|||
| if (shouldHeaderBeSlim) { | |||
There was a problem hiding this comment.
Does this solution take into account really long words, which can be problematic also when header is not slim?
tischsoic
approved these changes
Mar 2, 2023
Gengar-i
approved these changes
Mar 3, 2023
GrabowskiM
force-pushed
the
IBX-5138-the-header-in-content-edit-view-is-displayed-incorrectly-when-scrolling
branch
from
5ff0d90 to
b67202a
Compare
GrabowskiM
force-pushed
the
IBX-5138-the-header-in-content-edit-view-is-displayed-incorrectly-when-scrolling
branch
from
b67202a to
fc222a5
Compare
jwibexa
approved these changes
Mar 6, 2023
mnocon
requested changes
Mar 7, 2023
There was a problem hiding this comment.
I've looked into the CI failure and looks like there's an issue here - the "Create" (or Save) button is clickable only when the website is not scrolled, you can't click it once you scroll below on the website
bug.mov
Please notice how the "on hover" pointer change does not happen when I scroll down - the button cannot be clicked.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Manually restesed after the "fit bottom row line with buttons" commit |
dew326
deleted the
IBX-5138-the-header-in-content-edit-view-is-displayed-incorrectly-when-scrolling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
$ composer fix-cs)