IBX-5606: Removed duplicated GraphQL request in the Subitems module

[barw4]

Question	Answer
Tickets	https://issues.ibexa.co/browse/IBX-5606
Bug fix?	yes
New feature?	no
BC breaks?	no
Tests pass?	yes
Doc needed?	no
License	GPL-2.0

The containerResizeObserver injected into componentDidMount method actually causes double GraphQL requests. Component is immediately updated because of containerResizeObserver, hence firing componentDidUpdate method, hence second GraphQL request.

Checklist:

• Coding standards ($ composer fix-cs)
• Ready for Code Review

[dew326]

Why resizeObserver triggers loading items, it doesn't seem right in the first place. Trigger loading items on didMount sounds like proper behavior.

[barw4]

@dew326 it triggers loading as observer triggers componentDidUpdate and at the point of running

        const shouldLoadPage = !activePageItems;

        if (shouldLoadPage) {
            this.loadPage(activePageIndex);
        }

in componentDidUpdate we have no active page items, hence the additional call to loadPage.

[dew326]

so it should be stopped there because resize should not trigger loading items but didMount should.

[dew326]

the approach should be changed

[barw4]

@dew326 is this what you had in mind? f4e9dba

[dew326]

no, I meant additional check because you probably broke pagination in this solution.

[barw4]

@dew326 additional check to verify whether we are actually resizing window and not changing pagination?

[dew326]

yes, if we resize skip loading items.

[barw4]

@dew326 actually I think we are better off not updating the component every time if the size is the same. This solves the problem in the description.

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[micszo]

QA Approved on Ibexa Commerce 4.4.4-dev.