IBX-5583: Fix multiselect dropdown not firing change event #776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… option when selcted/unselected at least twice in a row
tischsoic
requested review from
GrabowskiM,
dew326,
lucasOsti,
konradoboza and
Gengar-i
tischsoic
commented
Apr 28, 2023
| @@ -183,7 +183,7 @@ | |||
|
|
|||
| this.fitItems(); | |||
|
|
|||
| if (this.currentSelectedValue !== value) { | |||
| if (this.currentSelectedValue !== value || !this.canSelectOnlyOne) { | |||
There was a problem hiding this comment.
Note: for multi-select dropdown, we want to fire the event every single time.
|
Kudos, SonarCloud Quality Gate passed!
|
GrabowskiM
approved these changes
Apr 28, 2023
Gengar-i
approved these changes
Apr 28, 2023
konradoboza
approved these changes
Apr 28, 2023
dew326
approved these changes
Apr 28, 2023
tomaszszopinski
approved these changes
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix multi-select dropdown not firing change event for the first option when selected/unselected at least twice in a row