Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5784: CkEditor toolbar overflow fix #807

Merged
merged 2 commits into from
Jun 13, 2023
Merged

IBX-5784: CkEditor toolbar overflow fix #807

merged 2 commits into from
Jun 13, 2023

Conversation

Gengar-i
Copy link
Contributor

@Gengar-i Gengar-i commented Jun 5, 2023 •
edited
Loading

Question Answer
Tickets IBX-5784
IBX-5743
IBX-4329
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no

CkEditor toolbar overflow fix

Checklist:

  • Coding standards (yarn test)
  • Ready for Code Review

@Gengar-i Gengar-i changed the base branch from main to 4.4 June 5, 2023 14:21
@Gengar-i Gengar-i requested a review from GrabowskiM June 12, 2023 08:22
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tomaszszopinski
tomaszszopinski approved these changes Jun 13, 2023
View reviewed changes
Copy link
Contributor

@tomaszszopinski tomaszszopinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA approved on IbexaDXP 4.4 commerce.

@dew326 dew326 merged commit 6c79e92 into 4.4 Jun 13, 2023
@dew326 dew326 deleted the ibx-5784-cd-editor-toolbar-overflow branch June 13, 2023 11:49
@Gengar-i
Copy link
Contributor Author

Merge to 4.5: 5db40a0
Merge to 4.6: 75ddfcb

Gengar-i added a commit that referenced this pull request Jun 14, 2023
@Gengar-i
Revert "IBX-5784: CkEditor toolbar overflow fix (#807)"
6e2649c 
This reverts commit 6c79e92.
@Gengar-i Gengar-i mentioned this pull request Jun 14, 2023
Merged
dew326 pushed a commit that referenced this pull request Jun 14, 2023
@Gengar-i
Revert "IBX-5784: CkEditor toolbar overflow fix" (#811)
19ab7d7 
Revert "IBX-5784: CkEditor toolbar overflow fix (#807)"

This reverts commit 6c79e92.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@dew326 dew326 dew326 approved these changes

@tischsoic tischsoic tischsoic approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

Assignees

@dew326 dew326

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Gengar-i @GrabowskiM @tischsoic @dew326 @lucasOsti @tomaszszopinski