Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-6566: As a Editor I'd like to get content type suggestions while creating content in given location #906

Merged
merged 6 commits into from
Dec 1, 2023

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Sep 13, 2023

Question Answer
Tickets https://issues.ibexa.co/browse/IBX-6566
Bug fix? no
New feature? yes
BC breaks? no
Tests pass? yes
Doc needed? yes
License GPL-2.0

It's very common to have items of the same or very limited number of types inside single container. For example:

Location Content Type
/Media/Images Images
/Media/Files File
/Forms Form
/Users User Group
/Users/**/ User

This PR adds content type suggestions to content creation form

image

and reduce time needed to finding appropriate content type on the list.

Implementation

Suggestions are computed using AI Aggregation API as n most frequently used content types in given location.

Checklist:

  • Coding standards ($ composer fix-cs)
  • Ready for Code Review

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

phpstan-baseline.neon Outdated Show resolved Hide resolved
@adamwojs adamwojs requested a review from a team November 2, 2023 22:40
@adamwojs adamwojs force-pushed the content_create_suggestions branch from 511ce42 to 4ff99fa Compare November 15, 2023 05:49
@katarzynazawada
Copy link
Contributor

@adamwojs in Admin->Corporate when there are added companies (by Customers->Companies), it is displayed in the suggestions, but from here there is no option to add a company
Screenshot 2023-11-16 at 14 37 55

@katarzynazawada
Copy link
Contributor

I found one small inconsistency, but I'm not sure if we can do anything about it. When removing content via the sub-item list, the given content type is still visible in the suggestions (probably because the page is not automatically reloaded). When manually reloaded, the suggestion disappears. See https://recordit.co/VubVIvEysN

@katarzynazawada
Copy link
Contributor

Agreed with @NataliaBecla that it would be nice to have it also in COFT content type picker to maintain consistency 🙂
Screenshot 2023-11-16 at 14 10 10

@adamwojs adamwojs force-pushed the content_create_suggestions branch from 4ff99fa to ec8056d Compare November 25, 2023 10:21
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamwojs
Copy link
Member Author

@adamwojs in Admin->Corporate when there are added companies (by Customers->Companies), it is displayed in the suggestions, but from here there is no option to add a company

Feedback addressed in eeb1996

@adamwojs
Copy link
Member Author

I found one small inconsistency, but I'm not sure if we can do anything about it. When removing content via the sub-item list, the given content type is still visible in the suggestions (probably because the page is not automatically reloaded). When manually reloaded, the suggestion disappears. See https://recordit.co/VubVIvEysN

Yes, page reload is necessary to update the content create form. IMHO we can skip this edge case as we don't take it into account in case of other UI elements.

@adamwojs
Copy link
Member Author

Agreed with @NataliaBecla that it would be nice to have it also in COFT content type picker to maintain consistency 🙂

@GrabowskiM Could you please help me apply this comment ?

Copy link
Contributor

@katarzynazawada katarzynazawada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with solr and Elasticsearch. Missing suggestions in COFT reported separately https://issues.ibexa.co/browse/IBX-7271

@adamwojs adamwojs merged commit 6bcab75 into main Dec 1, 2023
23 checks passed
@adamwojs adamwojs deleted the content_create_suggestions branch December 1, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants