IBX-6838: [Smart mode] As the User I want to enter Columns settings in Subitems and add/remove columns #984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kisztof
force-pushed
the
ibx-6838-subitems
branch
from
b532539 to
86531f5
Compare
kisztof
force-pushed
the
ibx-6838-subitems
branch
from
86531f5 to
c450eec
Compare
mikadamczyk
reviewed
Nov 14, 2023
src/bundle/Resources/views/themes/admin/content/location_view.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content/tab/sub_items.html.twig
Outdated
Show resolved
Hide resolved
src/bundle/Resources/views/themes/admin/content/tab/sub_items.html.twig
Outdated
Show resolved
Hide resolved
| ] %} | ||
|
|
||
| {% include '@ibexadesign/ui/component/details/details.html.twig' with { | ||
| headline: 'tab.subitems.sub_items'|trans()|desc('Sub Items'), |
There was a problem hiding this comment.
Suggested change
| headline: 'tab.subitems.sub_items'|trans()|desc('Sub Items'), | |
| headline: 'tab.subitems.sub_items'|trans|desc('Sub Items'), |
src/bundle/Resources/views/themes/admin/ui/component/sub_items/sub_items.html.twig
Outdated
Show resolved
Hide resolved
konradoboza
reviewed
Nov 14, 2023
GrabowskiM
force-pushed
the
ibx-6838-subitems
branch
3 times, most recently
from
7dafc15 to
12d5cf0
Compare
2 tasks
tischsoic
approved these changes
Nov 20, 2023
konradoboza
approved these changes
Nov 20, 2023
lucasOsti
approved these changes
Nov 20, 2023
dew326
approved these changes
Nov 20, 2023
kisztof
force-pushed
the
IBX-6839-authors-tab
branch
from
7f429df to
6832b6c
Compare
Co-authored-by: Mikolaj Adamczyk <mikolaj.adamczyk@ez.no>
webhdx
force-pushed
the
ibx-6838-subitems
branch
from
9223772 to
4002e24
Compare
|
I made a mistake and merged PRs in wrong order, had to rebase your PR on current |
Gengar-i
approved these changes
Nov 21, 2023
|
SonarCloud Quality Gate failed.
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves subitems to separate tab
Checklist:
$ composer fix-cs)