Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Rebranded temporary directory prefix used by Core IO tests #178

Merged
merged 1 commit into from
Dec 12, 2022
Merged

[Tests] Rebranded temporary directory prefix used by Core IO tests #178

merged 1 commit into from
Dec 12, 2022

Conversation

alongosz
Copy link
Member

Question Answer
JIRA issue Discovered while working on IBX-1439
Type bug
Target Ibexa version v4.3+
BC breaks no BC promise for tests

Fixed outstanding directory naming of a temporary directory create by Legacy Setup Factory for Core IO tests.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage // already there.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review.

@alongosz alongosz added Bug Something isn't working Ready for review labels Dec 12, 2022
@alongosz alongosz requested a review from a team December 12, 2022 12:03
@konradoboza konradoboza requested a review from a team December 12, 2022 12:04
@alongosz alongosz merged commit 5ec6cb5 into 4.3 Dec 12, 2022
@alongosz alongosz deleted the rebrand-integration-tests-dir-name branch December 12, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@ciastektk ciastektk ciastektk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@adamwojs adamwojs adamwojs approved these changes

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

Labels
Bug Something isn't working Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alongosz @adamwojs @mikadamczyk @Steveb-p @ciastektk @konradoboza