Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5541: Fixed Alias Generators' service priorities #228

Merged
merged 2 commits into from
May 15, 2023
Merged

IBX-5541: Fixed Alias Generators' service priorities #228

merged 2 commits into from
May 15, 2023

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Apr 26, 2023

Question Answer
JIRA issue IBX-5541
Type bug
Target Ibexa version v4.4
BC breaks no

Seems like the first AliasGenerator fired was Ibexa\Bundle\Core\Imagine\AliasGenerator but it should be Ibexa\Bundle\Core\Imagine\ImageAsset\AliasGenerator.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@barw4 barw4 added Bug Something isn't working Ready for review labels Apr 26, 2023
@barw4 barw4 requested a review from a team April 26, 2023 10:42
@barw4 barw4 self-assigned this Apr 26, 2023
@Steveb-p
Copy link
Contributor

Can we lower these priorities instead?

The most generic one should be, for example -100, while the one related to Imagine could be -50. That way any services declared by users will go first (default priority 0).

@barw4
Copy link
Contributor Author

barw4 commented Apr 26, 2023

@Steveb-p sure, done

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mnocon mnocon self-assigned this May 12, 2023
mnocon
mnocon approved these changes May 15, 2023
View reviewed changes
Copy link
Contributor

@mnocon mnocon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this with steps from the ticket and by playing with image variations for embedded items in Richtext editor.

Looks good, QA approved!

@alongosz alongosz merged commit 1330649 into 4.4 May 15, 2023
@alongosz alongosz deleted the ibx-5541-fix-alias-generator-services-order branch May 15, 2023 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@mnocon mnocon mnocon approved these changes

@alongosz alongosz alongosz approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@kisztof kisztof kisztof approved these changes

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

@mnocon mnocon

@barw4 barw4

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@barw4 @Steveb-p @kisztof @alongosz @mnocon @konradoboza @adamwojs @mikadamczyk @ciastektk