Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6032: Undeprecated single object relation field type #243

Merged
merged 1 commit into from
Jun 27, 2023
Merged

IBX-6032: Undeprecated single object relation field type #243

merged 1 commit into from
Jun 27, 2023

Conversation

adamwojs
Copy link
Member

Question Answer
JIRA issue IBX-6032
Type improvement
Target Ibexa version v4.6
BC breaks no

Single object relation field type is deprecated since eZ Platform 2.0. However after reconsideration we decided to keep it in the code base, as it's might be great foundation for custom specialized field types.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alongosz alongosz merged commit a87efec into main Jun 27, 2023
@alongosz alongosz deleted the ibx_6032 branch June 27, 2023 06:17
@adriendupuis adriendupuis mentioned this pull request May 16, 2024
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

@ciastektk ciastektk ciastektk approved these changes

@alongosz alongosz alongosz approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

Assignees

@adamwojs adamwojs

@mikadamczyk mikadamczyk

@Steveb-p Steveb-p

@alongosz alongosz

@ciastektk ciastektk

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@adamwojs @mikadamczyk @alongosz @ciastektk @ViniTou @konradoboza @Steveb-p