Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5936: Added ContentTypeHandler::loadContentTypesByFieldDefinitionIdentifier method #249

Merged
merged 4 commits into from
Aug 8, 2023
Merged

IBX-5936: Added ContentTypeHandler::loadContentTypesByFieldDefinitionIdentifier method #249

merged 4 commits into from
Aug 8, 2023

Conversation

konradoboza
Copy link
Contributor

@konradoboza konradoboza commented Jul 26, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-5936
Type bug
Target Ibexa version v4.5, main
BC breaks no

Added mentioned method to be utilized within https://github.com/ibexa/product-catalog/pull/1034.

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (main for features, the oldest supported for bugs).
  • Ran PHP CS Fixer for new PHP code (use $ composer fix-cs).
  • Asked for a review (ping @ibexa/engineering).

@konradoboza konradoboza added the Bug Something isn't working label Jul 26, 2023
@konradoboza konradoboza self-assigned this Jul 26, 2023
@konradoboza konradoboza requested review from alongosz and a team July 26, 2023 09:29
@alongosz alongosz requested a review from a team July 28, 2023 15:49
@konradoboza konradoboza requested a review from alongosz July 31, 2023 07:33
@konradoboza konradoboza requested a review from a team July 31, 2023 07:53
@alongosz alongosz requested a review from a team July 31, 2023 08:21
@webhdx webhdx requested a review from a team July 31, 2023 08:28
@micszo micszo self-assigned this Aug 7, 2023
This was referenced Aug 7, 2023
Closed
Closed
@konradoboza konradoboza force-pushed the ibx-5936-additional-content-type-fetching-method branch from 4d6e76e to f712006 Compare August 8, 2023 06:42
@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@micszo micszo mentioned this pull request Aug 8, 2023
Closed
micszo
micszo approved these changes Aug 8, 2023
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with https://github.com/ibexa/product-catalog/pull/1034.

@micszo micszo removed their assignment Aug 8, 2023
@alongosz alongosz merged commit 74e2b93 into 4.5 Aug 8, 2023
@alongosz alongosz deleted the ibx-5936-additional-content-type-fetching-method branch August 8, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@micszo micszo micszo approved these changes

@webhdx webhdx webhdx approved these changes

@alongosz alongosz alongosz approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@kisztof kisztof kisztof approved these changes

Assignees

@kisztof kisztof

@mikadamczyk mikadamczyk

@alongosz alongosz

@konradoboza konradoboza

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@konradoboza @kisztof @Steveb-p @alongosz @webhdx @micszo @mikadamczyk