Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHPDoc] Improved definitions #397

Merged
merged 6 commits into from
Jul 4, 2024
Merged

[PHPDoc] Improved definitions #397

merged 6 commits into from
Jul 4, 2024

Conversation

mnocon
Copy link
Contributor

@mnocon mnocon commented Jul 1, 2024 •
edited
Loading

These PR does two things:

  1. Fixes the Field error from https://doc.ibexa.co/en/latest/api/php_api/php_api_reference/reports/errors.html
  2. Converts the link tags to see tags when appropriate

I tried to avoid other changes to keep the scope of this PR easier to manage

@mnocon mnocon changed the title Fix php ref definitions [PHPDoc] Improved definitions Jul 1, 2024
@mnocon mnocon marked this pull request as ready for review July 1, 2024 11:48
@mnocon mnocon marked this pull request as draft July 1, 2024 12:43
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 1, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

adriendupuis
adriendupuis reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@adriendupuis adriendupuis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some link still doesn't work. See my first comment with two proposal. For the following suggestion, I choose to not hide the class name event if it's the current class. This is debatable.

[Edit: solved]

src/contracts/FieldType/FieldType.php Outdated Show resolved Hide resolved
src/contracts/FieldType/FieldType.php Outdated Show resolved Hide resolved
src/contracts/FieldType/FieldType.php Outdated Show resolved Hide resolved
src/contracts/FieldType/FieldType.php Outdated Show resolved Hide resolved
src/contracts/FieldType/FieldType.php Outdated Show resolved Hide resolved
src/contracts/Repository/FieldType.php Outdated Show resolved Hide resolved
src/contracts/Repository/FieldType.php Outdated Show resolved Hide resolved
src/contracts/Repository/FieldType.php Outdated Show resolved Hide resolved
src/contracts/Repository/Values/Content/Relation.php Outdated Show resolved Hide resolved
src/contracts/Repository/Values/Content/VersionInfo.php Outdated Show resolved Hide resolved
@mnocon mnocon marked this pull request as ready for review July 2, 2024 19:38
@mnocon mnocon requested a review from a team July 3, 2024 06:08
@konradoboza konradoboza requested a review from a team July 3, 2024 06:12
@alongosz alongosz requested review from a team and adriendupuis July 3, 2024 12:36
mnocon and others added 5 commits July 4, 2024 07:36
@mnocon
[PHPDoc] Converted link tags to see
0e29ade
@mnocon
Fixed PHPStan baseline
b6ad0a9
@mnocon @adriendupuis
Apply suggestions from code review
328aa8f 
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
@mnocon @alongosz
Apply suggestions from code review
274cda3 
Co-authored-by: Andrew Longosz <alongosz@users.noreply.github.com>
@mnocon @adriendupuis
Update src/contracts/Repository/Values/Content/Relation.php
fd2f7a9 
Co-authored-by: Adrien Dupuis <61695653+adriendupuis@users.noreply.github.com>
@mnocon mnocon force-pushed the fix-php-ref-definitions branch from a3da3e4 to fd2f7a9 Compare July 4, 2024 05:37
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jul 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz merged commit e710a6e into 4.6 Jul 4, 2024
21 checks passed
@alongosz alongosz deleted the fix-php-ref-definitions branch July 4, 2024 09:39
@mnocon mnocon mentioned this pull request Jul 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriendupuis adriendupuis adriendupuis approved these changes

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@mikadamczyk mikadamczyk

@alongosz alongosz

@tischsoic tischsoic

Labels
Ready for MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mnocon @alongosz @konradoboza @adriendupuis @mikadamczyk @tischsoic