IBX-8469: Fixed image filtering by file size float value #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciastektk
changed the title
alongosz
reviewed
Aug 8, 2024
src/contracts/Repository/Values/Content/Query/Criterion/Image/FileSize.php
Outdated
Show resolved
Hide resolved
Steveb-p
approved these changes
Aug 8, 2024
src/contracts/Repository/Values/Content/Query/Criterion/Image/FileSize.php
Outdated
Show resolved
Hide resolved
Steveb-p
reviewed
Aug 8, 2024
src/contracts/Repository/Values/Content/Query/Criterion/Image/FileSize.php
Show resolved
Hide resolved
konradoboza
approved these changes
Aug 8, 2024
ciastektk
force-pushed
the
ibx-8469-fixed-image-file-size-filtering-by-float-values
branch
from
54bc30d to
3e7a7fa
Compare
ciastektk
force-pushed
the
ibx-8469-fixed-image-file-size-filtering-by-float-values
branch
from
3e7a7fa to
8f84db9
Compare
mikadamczyk
approved these changes
Aug 12, 2024
Steveb-p
reviewed
Aug 12, 2024
src/contracts/Repository/Values/Content/Query/Criterion/Image/AbstractImageRangeCriterion.php
Show resolved
Hide resolved
ciastektk
force-pushed
the
ibx-8469-fixed-image-file-size-filtering-by-float-values
branch
from
3edc25e to
c3b9ef9
Compare
|
This was referenced Aug 20, 2024
bogusez
approved these changes
Aug 21, 2024
alongosz
approved these changes
Aug 21, 2024
alongosz
deleted the
ibx-8469-fixed-image-file-size-filtering-by-float-values
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Float values in file size filter causes error when using solr search engine. This PR adds cast to int value converted to bytes and allows to use float values.
For QA:
Documentation: