-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-9103: Add RelationType for filtering purposes to fetch relations methods #440
Conversation
3f90ff6
to
06b1306
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I assume there is no option of introducing yet another relation type, in which case an enum
is warranted.
If no relation type is passed, all relations are counted, right?
Oh, I guess it was not documented but it wasn't so hard to do, so probably for BC point I would have to revert enum back to consts, unless you see some better option.
yup, no change here. |
Quality Gate passedIssues Measures |
Related PRs: (needed for CI to pass!)
Description:
If we decide to go with the enum I will create another PR with replacment, rector rule and changing it in our codebase.
To Discuss:
Should we also deprecate
loadReverseRelations
method? There already isloadReverseRelationList
for substitutions and it seems as an oversight tbh.For QA:
Documentation:
🟢 ibexa/commerce#1087