Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IBX-9103: Add RelationType for filtering purposes to fetch relations methods #440

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

ViniTou
Copy link
Contributor

@ViniTou ViniTou commented Oct 18, 2024

🎫 Issue IBX-9103

Related PRs: (needed for CI to pass!)

Description:

If we decide to go with the enum I will create another PR with replacment, rector rule and changing it in our codebase.

To Discuss:

Should we also deprecate loadReverseRelations method? There already is loadReverseRelationList for substitutions and it seems as an oversight tbh.

For QA:

Documentation:

🟢 ibexa/commerce#1087

@ViniTou ViniTou requested a review from a team October 22, 2024 11:11
Copy link
Contributor

@Steveb-p Steveb-p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume there is no option of introducing yet another relation type, in which case an enum is warranted.

If no relation type is passed, all relations are counted, right?

src/contracts/Repository/Values/Content/Relation.php Outdated Show resolved Hide resolved
@ViniTou
Copy link
Contributor Author

ViniTou commented Oct 23, 2024

@Steveb-p

I assume there is no option of introducing yet another relation type

Oh, I guess it was not documented but it wasn't so hard to do, so probably for BC point I would have to revert enum back to consts, unless you see some better option.

If no relation type is passed, all relations are counted

yup, no change here.

@alongosz alongosz requested a review from a team October 23, 2024 08:39
Copy link

@alongosz alongosz merged commit fed1a91 into main Oct 23, 2024
14 checks passed
@alongosz alongosz deleted the ibx-x-extend-relations-api branch October 23, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants