-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issues related to twig/twig 3.15 in tests #455
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to have our own base class for extensions then? Not a huge fan of traits, especially the ones used in the object of the same base.
+1, given this is a quick fix for failing CI
src/lib/MVC/Symfony/Templating/Twig/Extension/DeprecationOptionsTrait.php
Show resolved
Hide resolved
I've considered making this an abstract. My argument against is that this is a particular behavior that will be gone with 5.0. By making it a trait, it will be more easily removed. Without touching the extension tree. |
src/lib/MVC/Symfony/Templating/Twig/Extension/DeprecationOptionsTrait.php
Show resolved
Hide resolved
src/lib/MVC/Symfony/Templating/Twig/Extension/DeprecationOptionsTrait.php
Outdated
Show resolved
Hide resolved
Quality Gate failedFailed conditions |
Merged up into |
Description:
This PR fixes issues related to recent
twig/twig
3.15 release, which changes how deprecation information should be passed into Twig Extensions.To maintain compatibility with earlier Twig versions (most recent PHP 7.4 compatible version of Twig is 3.11) a specific class check is used.
Due to small differences in Twig output, snapshots of results for Twig templating is split between 8.0/7.4 versions where applicable.
For QA:
Documentation: