IBX-2432: Removed unused dependency from SelecionConverter #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pspanja
force-pushed
the
IBX-2432_selection_converter
branch
from
97f44ef to
04dbcc9
Compare
|
@alongosz unsure about the complaints, any tips? |
pspanja
force-pushed
the
IBX-2432_selection_converter
branch
from
04dbcc9 to
6e93d5a
Compare
alongosz
requested changes
Feb 25, 2022
There was a problem hiding this comment.
@pspanja this is a PHPStan report. There was a bug - technical debt - committed to ./phpstan-baseline.neon for future review and fixing. It is caused by \Ibexa\Core\Persistence\Legacy\Content\FieldValue\Converter\SelectionConverter::create which invokes constructor without arguments. It was incorrect, now it's correct, since you dropped that argument, so you can remove this report from ./phpstan-baseline.neon (lines 183-187).
alongosz
approved these changes
Mar 1, 2022
alongosz
changed the title
mikadamczyk
approved these changes
Mar 1, 2022
Steveb-p
approved these changes
Mar 1, 2022
adamwojs
approved these changes
Mar 2, 2022
|
Thank you @pspanja! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.0Repository LanguageService is not used in the SelectionConverter and it also does not belong in this layer.
Checklist:
$ composer fix-cs).@ibexa/engineering).