-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from v4.4.x to v4.5 #1975
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested this guide together with https://github.com/ibexa/installer/pull/99/ and https://github.com/ibexa/installer/pull/101
-
There are new tables, available in the OSS version, that don't have an upgrade script (ibexa_token and ibexa_token_type)
Added in IBX-5314: Implemented token storage core#217 -
There's no mention of the Shipment and Order policies added by default
I think these two migrations are responsible for them:
https://github.com/ibexa/shipping/blob/main/src/bundle/Resources/install/migrations/shipment_permissions.yaml
https://github.com/ibexa/order-management/blob/main/src/bundle/Resources/install/migrations/order_permissions.yaml
- There are differences in database schema between normal installation and an upgrade
a) ibexa_payment table:
in our schema the owner field is nullable: https://github.com/ibexa/payment/blob/main/src/bundle/Resources/config/schema.yaml#L121-L123
in the script it's not: https://github.com/ibexa/installer/pull/101/files#diff-3acc61ccaf8c51bec0207363c084661b3c914faf7facef830a3402512dc7a557R418
b) ibexa_order table:
the identifier column does not have the uuid
type after the upgrade
the lenght of the source column has different lenghts (190 vs 255)
https://github.com/ibexa/order-management/blob/main/src/bundle/Resources/config/schema.yaml#L10-L26
https://github.com/ibexa/installer/blob/5416-added-shipping-upgrade-scripts/upgrade/db/postgresql/commerce/ibexa-4.4.latest-to-4.5.0.sql#L9
### Update the database | ||
|
||
Next, update the database if you are using Ibexa Commerce. | ||
Ibexa Content and Ibexa Experience do not require the database update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not true, there's a script to execute:
https://github.com/ibexa/installer/blob/main/upgrade/db/postgresql/ibexa.4.4.latest-to-4.5.0.sql
for Content and Experience (and a new table for OSS)
BTW for some reason it doesn't follow our naming convention, we should rename it to match it (see all the names here: https://github.com/ibexa/installer/tree/main/upgrade/db/postgresql)
|
||
- Corporate account — this migration allows all company members to shop in the frontend shop. If you have implemented business logic that depends on keeping company members out of the frontend shop, you can skip it: | ||
|
||
```bash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something is wrong here, because the files mentioned below ((2023_04_27_10_30_corporate_account, 2023_04_27_11_20_storefront_user_role_update) do not exist in the Storefront package
https://github.com/ibexa/storefront/tree/main/src/bundle/Resources/migrations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, tje PR is still waiting for merge, I was sure it will be added to rc: https://github.com/ibexa/storefront/pull/100
This should be fixed via: |
Upgrade scripts for token tables: https://github.com/ibexa/installer/pull/105 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It works! 🎉
Checklist