Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-6217: Forced RichText\Rendererto utilize PermissionResolver instead of AuthorizationChecker #118

Merged
merged 10 commits into from
Aug 16, 2023
Merged

IBX-6217: Forced RichText\Rendererto utilize PermissionResolver instead of AuthorizationChecker #118

merged 10 commits into from
Aug 16, 2023

Conversation

barw4
Copy link
Contributor

@barw4 barw4 commented Aug 7, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-6217
Improvement yes
New feature no
Target version v4.5
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@barw4 barw4 self-assigned this Aug 7, 2023
@barw4 barw4 requested a review from a team August 7, 2023 14:32
@alongosz alongosz requested a review from a team August 7, 2023 15:54
@barw4 barw4 requested a review from alongosz August 7, 2023 16:35
konradoboza
konradoboza reviewed Aug 8, 2023
View reviewed changes
tests/lib/RichText/RendererTest.php Outdated Show resolved Hide resolved
tests/lib/RichText/RendererTest.php Outdated Show resolved Hide resolved
tests/lib/RichText/RendererTest.php Outdated Show resolved Hide resolved
tests/lib/RichText/RendererTest.php Outdated Show resolved Hide resolved
tests/lib/RichText/RendererTest.php Outdated Show resolved Hide resolved
tests/lib/RichText/RendererTest.php Outdated Show resolved Hide resolved
@konradoboza konradoboza requested a review from a team August 8, 2023 06:09
@barw4 barw4 requested a review from konradoboza August 8, 2023 13:11
konradoboza
konradoboza approved these changes Aug 9, 2023
View reviewed changes
tests/lib/RichText/RendererTest.php Outdated Show resolved Hide resolved
@konradoboza konradoboza requested a review from a team August 9, 2023 06:08
@alongosz alongosz requested a review from a team August 9, 2023 07:25
jwibexa
jwibexa approved these changes Aug 14, 2023
View reviewed changes
Copy link

@jwibexa jwibexa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and validated on 4.5 experience

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@konradoboza konradoboza merged commit 7468d49 into 4.5 Aug 16, 2023
@konradoboza konradoboza deleted the ibx-6217-Renderer-PermissionResolver branch August 16, 2023 09:01
@barw4 barw4 mentioned this pull request Sep 19, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwibexa jwibexa jwibexa approved these changes

@konradoboza konradoboza konradoboza approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@alongosz alongosz

@barw4 barw4

@konradoboza konradoboza

Labels
Improvement QA approved Ready for QA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@barw4 @alongosz @konradoboza @jwibexa @adamwojs