IBX-6843: Focus mode #133
Merged
IBX-6843: Focus mode #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
lucasOsti
commented
Oct 24, 2023
•
lucasOsti
commented
| Question | Answer |
|---|---|
| JIRA issue | IBX-6843 |
| Bug/Improvement | Improvement |
| New feature | yes |
| Target version | 4.6 |
| BC breaks | no |
| Tests pass | yes |
| Doc needed | yes |
lucasOsti
force-pushed
the
IBX-6843-focus-mode
branch
9 times, most recently
from
326e28f to
53544a0
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
lucasOsti
force-pushed
the
IBX-6843-focus-mode
branch
from
53544a0 to
5b89c97
Compare
2 tasks
GrabowskiM
requested changes
Oct 30, 2023
Comment on lines
236
to
239
| const toolbarNodeRect = toolbarNode.getBoundingClientRect(); | ||
| const dataSourceNodeRect = dataSourceNode.getBoundingClientRect(); | ||
| const { height: toolbarHeight } = toolbarNodeRect; | ||
| const { top: dataSourceTop } = dataSourceNodeRect; |
There was a problem hiding this comment.
I don't think these two extra variables are necessary here
Suggested change
| const toolbarNodeRect = toolbarNode.getBoundingClientRect(); | |
| const dataSourceNodeRect = dataSourceNode.getBoundingClientRect(); | |
| const { height: toolbarHeight } = toolbarNodeRect; | |
| const { top: dataSourceTop } = dataSourceNodeRect; | |
| const { height: toolbarHeight } = toolbarNode.getBoundingClientRect(); | |
| const { top: dataSourceTop } = dataSourceNode.getBoundingClientRect(); |
Gengar-i
approved these changes
Oct 31, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
GrabowskiM
approved these changes
Nov 3, 2023
dew326
approved these changes
Nov 6, 2023
micszo
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.