IBX-7725: RTE area is hidden if custom-tag label is too long

[vidarl]

Question	Answer
JIRA issue	IBX-7725
Bug/Improvement	yes
New feature	no
Target version	4.5, main
BC breaks	no
Tests pass	yes
Doc needed	no

The label of the custom tag might hide the input field
The label is absolutely positioned before the input field, so the input field doesn't automatically float according to size of label

Before patch

After patch

TODO:

• Implement feature / fix a bug.
• Implement tests.
• Fix new code according to Coding Standards ($ composer fix-cs).
• Ask for Code Review.

[vidarl]

The label should strictly speaking be escaped. If so, how do you want it escaped?
For instance, adding " or </div> in translation file will break the html

[vidarl]

Also, changed title= into data-cke-tooltip-text=. Not sure if this is preferable or not

[vidarl]

[warn] src/bundle/Resources/public/js/CKEditor/custom-tags/block-custom-tag/custom-tag-editing.js
[warn] Code style issues found in the above file(s). Forgot to run Prettier?

I don't get it.. When running it locally, prettier doesn't complain about the file

[Gengar-i]

[warn] src/bundle/Resources/public/js/CKEditor/custom-tags/block-custom-tag/custom-tag-editing.js
[warn] Code style issues found in the above file(s). Forgot to run Prettier?

I don't get it.. When running it locally, prettier doesn't complain about the file

You need to install prettier with yarn and then update file with prettier.

Use yarn install in fieldtype-richtext.

[vidarl]

You need to install prettier with yarn and then update file with prettier.

Use yarn install in fieldtype-richtext.

Yeah, I got that part:

$ yarn prettier "./src/bundle/Resources/**/*.{js,scss}" -w
yarn run v1.22.17
(...)
src/bundle/Resources/public/js/CKEditor/custom-tags/block-custom-tag/custom-tag-editing.js 24ms (unchanged)
(...)

$ yarn prettier --version
yarn run v1.22.17
$ /var/www/vendor/ibexa/fieldtype-richtext/node_modules/.bin/prettier --version
3.2.5
Done in 0.21s.

@Gengar-i

[Gengar-i]

You need to install prettier with yarn and then update file with prettier.
Use yarn install in fieldtype-richtext.

Yeah, I got that part:

$ yarn prettier "./src/bundle/Resources/**/*.{js,scss}" -w
yarn run v1.22.17
(...)
src/bundle/Resources/public/js/CKEditor/custom-tags/block-custom-tag/custom-tag-editing.js 24ms (unchanged)
(...)

$ yarn prettier --version
yarn run v1.22.17
$ /var/www/vendor/ibexa/fieldtype-richtext/node_modules/.bin/prettier --version
3.2.5
Done in 0.21s.

@Gengar-i

With my prettier your changes modiefied looks differently.
Looks like prettier is not appling changes for you to this file.

[Gengar-i]

@vidarl I fixed prettier

[vidarl]

@vidarl I fixed prettier

Thank you

[dew326]

just code style

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[tomaszszopinski]

QA approved on IbexaDXP 4.5 commerce.