-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IBX-2961: Fixed extensibility point for adding plugins in CKEditor #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dew326
added
Bug
Something isn't working
Doc needed
The changes require some documentation
labels
Jun 10, 2022
alongosz
force-pushed
the
ckeditor-add-plugin
branch
from
June 13, 2022 13:29
2f555c8
to
e88a5ee
Compare
This was referenced Jun 13, 2022
alongosz
force-pushed
the
ckeditor-add-plugin
branch
2 times, most recently
from
June 14, 2022 11:52
8141006
to
e78e8f3
Compare
alongosz
changed the title
[WIP] IBX-2961: Fixed extensibility point for adding plugins in CKEditor
IBX-2961: Fixed extensibility point for adding plugins in CKEditor
Jun 14, 2022
adamwojs
reviewed
Jun 20, 2022
tests/bundle/DependencyInjection/ContainerParameterLoaderTrait.php
Outdated
Show resolved
Hide resolved
adamwojs
approved these changes
Jun 20, 2022
alongosz
approved these changes
Jun 20, 2022
tests/bundle/DependencyInjection/ContainerParameterLoaderTrait.php
Outdated
Show resolved
Hide resolved
tests/bundle/DependencyInjection/ContainerParameterLoaderTrait.php
Outdated
Show resolved
Hide resolved
damianz5
approved these changes
Jun 20, 2022
katarzynazawada
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v4.1
+Related changes:
Doc
See also ibexa/admin-ui#471 for Doc.
We need to extend this part of the documentation: https://doc.ibexa.co/en/latest/extending/extending_online_editor/#add-ckeditor-plugins
It is still needed to add plugin into the extraPlugins array, but it has to be done in a specific way.
The JS cannot be added by the default configManager or added in any encore entry. It has to be added to the
ibexa-richtext-onlineeditor-js
entry.So we introduced the new configManager which will handle adding JS to the CKEditor config.
The file that must be created is
ibexa.richtext.config.manager.js
either in the top level project folderencore
or in aResources/encore/
folder in the bundlethe code for
ibexa.richtext.config.manager.js
:TODO: