Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5297: Fixed custom tag without any attribute #82

Merged
merged 2 commits into from
May 18, 2023
Merged

IBX-5297: Fixed custom tag without any attribute #82

merged 2 commits into from
May 18, 2023

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Apr 20, 2023 •
edited
Loading

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-5297
Bug/Improvement yes
New feature no
Target version l4.4
BC breaks no
Tests pass yes
Doc needed no

For QA
Inline custom tags should be tested as well.
This PR should fix https://issues.ibexa.co/browse/IBX-5257 as well.

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@dew326 dew326 added the Bug Something isn't working label Apr 20, 2023
@dew326 dew326 self-assigned this Apr 20, 2023
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
40.9% 40.9% Duplication

@micszo micszo self-assigned this May 16, 2023
This was referenced May 18, 2023
Closed
Closed
micszo
micszo approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reproduced and retested the issues from tickets.

Sanities on custom tags OK. Also inline and nested.

QA Approved on Ibexa Commerce 4.4.4-dev.

@micszo micszo removed their assignment May 18, 2023
@dew326 dew326 merged commit dfe2b60 into 4.4 May 18, 2023
@dew326 dew326 deleted the fix-attrs-custom-tag branch May 18, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gengar-i Gengar-i Gengar-i approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@micszo micszo micszo approved these changes

@tischsoic tischsoic tischsoic approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

Assignees

@alongosz alongosz

@dew326 dew326

Labels
Bug Something isn't working QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dew326 @GrabowskiM @tischsoic @micszo @lucasOsti @Gengar-i @alongosz