Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-5741: Fixed collapsing Custom Tag attribute preview #91

Merged
merged 1 commit into from
Jun 23, 2023
Merged

IBX-5741: Fixed collapsing Custom Tag attribute preview #91

merged 1 commit into from
Jun 23, 2023

Conversation

dew326
Copy link
Contributor

@dew326 dew326 commented Jun 15, 2023

Question Answer
JIRA issue https://issues.ibexa.co/browse/IBX-5741
Bug/Improvement yes
New feature no
Target version v4.5
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement feature / fix a bug.
  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@dew326 dew326 self-assigned this Jun 15, 2023
@dew326 dew326 changed the base branch from main to 4.5 June 15, 2023 12:03
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.0% 10.0% Duplication

@dew326 dew326 changed the title Attribures close modal IBX-5741: Fixed attribute preview cannot be collapsed Jun 20, 2023
@micszo micszo self-assigned this Jun 23, 2023
micszo
micszo approved these changes Jun 23, 2023
View reviewed changes
Copy link
Contributor

@micszo micszo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Approved on Ibexa Experience 4.5.1-dev.

@micszo micszo removed their assignment Jun 23, 2023
@alongosz alongosz changed the title IBX-5741: Fixed attribute preview cannot be collapsed IBX-5741: Fixed collapsing Custom Tag attribute preview Jun 23, 2023
@alongosz alongosz merged commit cd54c30 into 4.5 Jun 23, 2023
@alongosz alongosz deleted the attribures-close-modal branch June 23, 2023 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gengar-i Gengar-i Gengar-i approved these changes

@lucasOsti lucasOsti lucasOsti approved these changes

@micszo micszo micszo approved these changes

@tischsoic tischsoic tischsoic approved these changes

@GrabowskiM GrabowskiM GrabowskiM approved these changes

Assignees

@alongosz alongosz

@dew326 dew326

Labels
QA approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@dew326 @GrabowskiM @tischsoic @micszo @lucasOsti @Gengar-i @alongosz