IBX-1993: Upgrade overblog/graphql-bundle to v0.14 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 15, 2022 12:01
…ierConnection Inheriting a relay-connection that doesn't specify a nodeType fails with v0.14. The fields from ItemByIdentifierConnection are moved to the generated types, and the generator updated accordingly.
bdunogier
force-pushed
the
ibx-1993-item_connection_nodeType
branch
from
56bc069 to
0118254
Compare
konradoboza
changed the title
konradoboza
approved these changes
Feb 22, 2022
mnocon
approved these changes
Feb 23, 2022
There was a problem hiding this comment.
I've discovered another GraphQL issue, not related to this PR: https://issues.ibexa.co/browse/IBX-2419
Other than that everything looks ok, QA approved
adamwojs
approved these changes
Feb 23, 2022
|
Hi, I'm sorry, I've missed something - looks like pagination in Subitems stops working when a Content Item has more than 10 children (the actual pagination should be visible) The error message is:
And it did not happen before this PR What would be the best way to approach this, should we revert this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA https://issues.ibexa.co/browse/IBX-1993.
This PR aims to bump
overblog/graphqldependency which offers full support for PHP8. Changes were required to adjust definitions that were lackingnodeTypeconfiguration key.