Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

french translation for 4.5 #36

Merged
merged 4 commits into from
Feb 27, 2024
Merged

french translation for 4.5 #36

merged 4 commits into from
Feb 27, 2024

Conversation

reithor
Copy link
Contributor

@reithor reithor commented Jan 19, 2024

JIRA: https://issues.ibexa.co/browse/IBX-7668

Most namespaces/domains for translation packages were changed for 4.6 by adding an ibexa_ prefix

See:
https://issues.ibexa.co/browse/IBX-6415
#32
https://crowdin.com/project/ibexa-dxp (crowd in filenames were also changed)

What was done to create this PR:

  • create branch 4-5-fr-update from 4.5 branch
  • copy files in i18n/translations/fr_FR/ from main branch to 4-5-fr-update branch
  • Run script that takes the files with ibexa_ prefix and rename those files to their old names by removing ibexa_ prefix or changing ibexa_ prefix to ezplatform_ prefix or do custom renaming in some cases.

Resulting branch could be merged to 4.5 - as this still uses "old" namespaces.
Changes were tested on 4.5.4 - works for me and french Back Office translations are improved.

while IFS= read -r -d '' file; do
    # single filename is in $file
    # check if oldfile without ibexa_ prefix exists  
    oldfile="${file/ibexa_/""}"
    if test -f "$oldfile"; then
        rm "$oldfile"
        mv "$file" "$oldfile"
        echo "$oldfile overwritten"
    else
        echo "$oldfile without ibexa_ prefix does not exist"
    fi

    # check if oldfile with ezplatform_ prefix exists  
    oldfile="${file/ibexa_/"ezplatform_"}"
    if test -f "$oldfile"; then
        rm "$oldfile"
        mv "$file" "$oldfile"
        echo "$oldfile overwritten"
    else
        echo "$oldfile with ezplatform_ prefix does not exist"
    fi
    #
done < <(find translations/fr_FR/ -name "ibexa_*" -print0)

# manual copies - for files that are available in ibexa/[bundle]/src/bundle/Resources/translations/ (4.6.x branch)
# but never were synced to ibexa/i18n (4.5.x branch)
mv translations/fr_FR/admin-ui/ibexa_admin_ui.fr.xlf translations/fr_FR/admin-ui/edit_translation_button.xlf
mv translations/fr_FR/fieldtype-page/ibexa_repository_exceptions.fr.xlf translations/fr_FR/fieldtype-page/repository_exceptions.fr.xlf
mv translations/fr_FR/form-builder/ibexa_repository_exceptions.fr.xlf translations/fr_FR/form-builder/repository_exceptions.fr.xlf
mv translations/fr_FR/scheduler/ibexa_scheduler.fr.xlf translations/fr_FR/scheduler/date_based_publisher.fr.xlf
mv translations/fr_FR/segmentation/ibexa_repository_exceptions.fr.xlf translations/fr_FR/segmentation/repository_exceptions.fr.xlf
mv translations/fr_FR/workflow/ibexa_repository_exceptions.fr.xlf translations/fr_FR/workflow/repository_exceptions.fr.xlf 

@reithor
Copy link
Contributor Author

reithor commented Jan 23, 2024

82b2d88
-> manual merge of translations where at least one translation id was removed in 4.6

@micszo micszo self-assigned this Feb 27, 2024
@mikadamczyk mikadamczyk merged commit 08cd198 into 4.5 Feb 27, 2024
2 checks passed
@mikadamczyk mikadamczyk deleted the 4-5-fr-update branch February 27, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants