Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-4516: Set a combination of 3 PHP & 3 Node versions. Ditched using default image. #103

Merged
merged 4 commits into from
Jul 20, 2023
Merged

IBX-4516: Set a combination of 3 PHP & 3 Node versions. Ditched using default image. #103

merged 4 commits into from
Jul 20, 2023

Conversation

micszo
Copy link
Contributor

@micszo micszo commented Jun 21, 2023 •
edited
Loading

Question Answer
JIRA issue IBX-4516
Type CI
Target Ibexa version v3.3
BC breaks no
Doc needed yes

Set 3 jobs to use:

  1. PHP 7.3 & Node 14
  2. PHP 7.4 & Node 16
  3. PHP 8.1 & Node 18

Test PR for 4.6: #104

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Checked that target branch is set correctly.
  • Asked for a review (ping @ibexa/engineering).

@micszo micszo changed the title [WIP] IBX-4516: Added image with Node 18 [WIP] IBX-4516: Added image with Node 18 and set as default Jul 7, 2023
@micszo micszo changed the title [WIP] IBX-4516: Added image with Node 18 and set as default [WIP] IBX-4516: Added image with Node 18 and set as default. Set PHP 8.1 as default. Jul 7, 2023
@micszo micszo changed the title [WIP] IBX-4516: Added image with Node 18 and set as default. Set PHP 8.1 as default. [WIP] IBX-4516: Set a combination of 3 PHP & 3 Node versions. Ditched using default image. Jul 7, 2023
@micszo micszo marked this pull request as ready for review July 13, 2023 12:40
@micszo micszo changed the title [WIP] IBX-4516: Set a combination of 3 PHP & 3 Node versions. Ditched using default image. IBX-4516: Set a combination of 3 PHP & 3 Node versions. Ditched using default image. Jul 13, 2023
This was referenced Jul 13, 2023
Merged
Merged
Merged
@mnocon mnocon merged commit b23b6c0 into 3.3 Jul 20, 2023
@micszo micszo deleted the ibx-4516-node-18-33 branch July 20, 2023 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@tomaszszopinski tomaszszopinski tomaszszopinski approved these changes

@mnocon mnocon mnocon approved these changes

@katarzynazawada katarzynazawada Awaiting requested review from katarzynazawada

@jwibexa jwibexa Awaiting requested review from jwibexa

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@micszo @mnocon @tomaszszopinski @bogusez