Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-2702: Allowed parsing objects which are not ValueObject based #33

Merged
merged 1 commit into from
Apr 12, 2022
Merged

IBX-2702: Allowed parsing objects which are not ValueObject based #33

merged 1 commit into from
Apr 12, 2022

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Apr 12, 2022 •
edited
Loading

Question Answer
JIRA issue IBX-2702
Type bug/feature/improvement
Target version v4.1
BC breaks no
Tests pass yes
Doc needed no

See JIRA issue for more details.

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs requested a review from a team April 12, 2022 13:14
@adamwojs adamwojs requested a review from a team April 12, 2022 13:15
@webhdx webhdx requested a review from a team April 12, 2022 13:15
@Nattfarinn Nattfarinn requested a review from a team April 12, 2022 13:20
@mikadamczyk mikadamczyk requested a review from a team April 12, 2022 13:39
@adamwojs adamwojs merged commit 61a281f into main Apr 12, 2022
@adamwojs adamwojs deleted the ibx_2702 branch April 12, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@konradoboza konradoboza konradoboza approved these changes

@ViniTou ViniTou ViniTou approved these changes

@webhdx webhdx webhdx approved these changes

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@mikadamczyk mikadamczyk mikadamczyk approved these changes

Assignees

@alongosz alongosz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@adamwojs @mikadamczyk @Steveb-p @Nattfarinn @webhdx @ViniTou @konradoboza @alongosz