Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-7512: Removed searching by partial words #44

Merged
merged 1 commit into from
Jan 18, 2024
Merged

IBX-7512: Removed searching by partial words #44

merged 1 commit into from
Jan 18, 2024

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Jan 17, 2024

Question Answer
Tickets IBX-7512
Bug fix? yes
New feature? no
BC breaks? no
Tests pass? yes
Doc needed? no
License GPL-2.0

@webhdx webhdx added Bug Something isn't working Ready for review labels Jan 17, 2024
@webhdx webhdx requested a review from a team January 17, 2024 10:24
@webhdx webhdx self-assigned this Jan 17, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bogusez bogusez self-assigned this Jan 17, 2024
@Steveb-p
Copy link
Contributor

Steveb-p commented Jan 17, 2024 •
edited
Loading

How does this affect the search exactly?

The issue described in the Jira is about not finding Content containing Ibexa in it's name, while searching using Ibe.
PR description states that it removes partial word search.

After this PR, will we receive the expected result described (Ibexa content found), or quite the contrary?

@webhdx
Copy link
Contributor Author

webhdx commented Jan 17, 2024 •
edited
Loading

Yeah sorry the ticket is misleading because it focuses on min_query_length limit but in reality FullText criterion on Elastic is not capable of using wildcards. The issue described in the ticket comes from that and not from the characters limit. It was decided that our autocomplete should only search for complete words.

@ciastektk ciastektk requested a review from a team January 17, 2024 10:54
@Steveb-p Steveb-p requested a review from a team January 17, 2024 11:43
This was referenced Jan 17, 2024
Closed
Closed
Closed
bogusez
bogusez approved these changes Jan 18, 2024
View reviewed changes
Copy link

@bogusez bogusez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression tests passed

@webhdx webhdx merged commit aaa3ed1 into main Jan 18, 2024
9 checks passed
@adamwojs adamwojs deleted the IBX-7512_simplified_fulltext_criterion branch January 18, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bogusez bogusez bogusez approved these changes

@konradoboza konradoboza konradoboza approved these changes

@ciastektk ciastektk ciastektk approved these changes

@Nattfarinn Nattfarinn Nattfarinn approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

Assignees

@webhdx webhdx

@ViniTou ViniTou

@bogusez bogusez

Labels
Bug Something isn't working QA approved Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@webhdx @Steveb-p @Nattfarinn @ciastektk @konradoboza @bogusez @ViniTou