Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-8119: Upgraded minimum PHP version to 8.3 #47

Merged
merged 2 commits into from
Jun 3, 2024
Merged

IBX-8119: Upgraded minimum PHP version to 8.3 #47

merged 2 commits into from
Jun 3, 2024

Conversation

alongosz
Copy link
Member

@alongosz alongosz commented Jun 3, 2024 •
edited
Loading

🎫 Issue IBX-8119
Blocks CI of #46

Description:

Seems there was never a PR created from this branch. Bumping PHP to 8.3

It includes:

  • changing composer.json requirements
  • sorting composer.json packages
  • updating GHA CI jobs config
  • fixing issue with iterables used as arrays which is recently reported by PHPStan. This time fix is simple so I've applied it right away instead of adding the issue to the baseline.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@alongosz alongosz requested review from tischsoic, ViniTou and a team June 3, 2024 09:40
@konradoboza konradoboza requested a review from a team June 3, 2024 09:41
@ViniTou ViniTou merged commit a10a618 into main Jun 3, 2024
9 checks passed
@ViniTou ViniTou deleted the ibx-8119-php-upgrade branch June 3, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ViniTou ViniTou ViniTou approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tischsoic tischsoic Awaiting requested review from tischsoic

Assignees

@tischsoic tischsoic

@ViniTou ViniTou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alongosz @ViniTou @konradoboza @tischsoic @Steveb-p