Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added base class for BuildSuggestionCollectionEvent event #51

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Added base class for BuildSuggestionCollectionEvent event #51

merged 1 commit into from
Dec 11, 2024

Conversation

adamwojs
Copy link
Member

🎫 Issue N/A

Description:

\Ibexa\Contracts\Search\Event\BuildSuggestionCollectionEvent class should extends \Symfony\Contracts\EventDispatcher\Event.

For QA:

N/A

Documentation:

N/A

ciastektk
ciastektk approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@ciastektk ciastektk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from red CI

@adamwojs adamwojs force-pushed the base_class_for_build_suggestion_event branch from 7c5e44b to 2331405 Compare December 11, 2024 12:37
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@adamwojs adamwojs merged commit 927f626 into 4.6 Dec 11, 2024
11 checks passed
@adamwojs adamwojs deleted the base_class_for_build_suggestion_event branch December 11, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@Steveb-p Steveb-p Steveb-p approved these changes

@ciastektk ciastektk ciastektk approved these changes

@konradoboza konradoboza konradoboza approved these changes

@tbialcz tbialcz tbialcz approved these changes

Assignees

@tischsoic tischsoic

@ViniTou ViniTou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@adamwojs @mikadamczyk @Steveb-p @ciastektk @konradoboza @tbialcz @tischsoic @ViniTou