[CI] Added phpstan #60
Conversation
ViniTou
force-pushed
the
add-phpstan
branch
2 times, most recently
from
7ec0987 to
0653c34
Compare
| @@ -272,6 +272,9 @@ private static function getStability(ComposerSystemInfo $composerInfo): string | |||
| return Stability::STABILITIES[$stabilityFlag]; | |||
| } | |||
|
|
|||
| /** | |||
| * @param list<string> $packageNames | |||
There was a problem hiding this comment.
Beacuse I do not know if it is int or string indexed, and it dosent matter for this function. List is just less hustle.
There was a problem hiding this comment.
Actually...
list<X> is basically equal to array<int, X>, with added assumption that keys will be always incrementing by 1. So it is in fact more narrow than array.
But yes, it should not matter in this context.
| @@ -146,7 +146,7 @@ class IbexaSystemInfoCollector implements SystemInfoCollector | |||
| private $kernelProjectDir; | |||
|
|
|||
| /** | |||
| * @param \Ibexa\Bundle\SystemInfo\SystemInfo\Collector\JsonComposerLockSystemInfoCollector|\Ibexa\Bundle\SystemInfo\SystemInfo\Collector\SystemInfoCollector $composerCollector | |||
| * @param \Ibexa\Bundle\SystemInfo\SystemInfo\Collector\JsonComposerLockSystemInfoCollector|SystemInfoCollector $composerCollector | |||
There was a problem hiding this comment.
FQCN was removed by accident.
| * @param \Ibexa\Bundle\SystemInfo\SystemInfo\Collector\JsonComposerLockSystemInfoCollector|SystemInfoCollector $composerCollector | |
| * @param \Ibexa\Bundle\SystemInfo\SystemInfo\Collector\JsonComposerLockSystemInfoCollector|\Ibexa\Bundle\SystemInfo\SystemInfo\Collector\SystemInfoCollector $composerCollector |
There was a problem hiding this comment.
I wonder if that even make much sense to have \Ibexa\Bundle\SystemInfo\SystemInfo\Collector\JsonComposerLockSystemInfoCollector here, as it is implementation of \Ibexa\Bundle\SystemInfo\SystemInfo\Collector\SystemInfoCollector
There was a problem hiding this comment.
If one is an interface that the other implements, then implementation can be removed from declaration.
| use PHPUnit\Framework\TestCase; | ||
|
|
||
| class SystemInfoViewBuilderTest extends TestCase | ||
| { | ||
| private $configuratorMock; | ||
| private Configurator $configuratorMock; |
There was a problem hiding this comment.
This should be more specific to what actually is inside, and fix on of the still reported PHPStan issues:
| private Configurator $configuratorMock; | |
| /** @var \PHPUnit\Framework\MockObject\MockObject&\Ibexa\Core\MVC\Symfony\View\Configurator */ | |
| private Configurator $configuratorMock; |
Similar thing can be done for registry and collector mocks.
There was a problem hiding this comment.
yeah, I wanted to do proper union type in main. I can add this atm as well tho.
|
Description:
For QA:
Documentation: