IBX-3070: User thumbnail should not be rendered with border and other minor bugs #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tischsoic
commented
Jun 22, 2022
•
tischsoic
commented
| Question | Answer |
|---|---|
| Tickets | https://issues.ibexa.co/browse/IBX-3070 |
| Bug fix? | yes/no |
| New feature? | no |
| BC breaks? | no |
| Tests pass? | yes |
| Doc needed? | no |
| License | GPL-2.0 |
dew326
approved these changes
Jun 23, 2022
ViniTou
approved these changes
Jun 23, 2022
GrabowskiM
approved these changes
Jun 23, 2022
lucasOsti
approved these changes
Jun 23, 2022
lucasOsti
approved these changes
Jun 23, 2022
dew326
approved these changes
Jun 23, 2022
tischsoic
force-pushed
the
IBX-3070-user-thumbnail
branch
from
6747193 to
5c137b3
Compare
tomaszszopinski
approved these changes
Jun 27, 2022
ViniTou
requested changes
Jun 27, 2022
| <ellipse ry="15" rx="15" cy="16" cx="16" fill="{{ background }}" stroke="#000000" stroke-width="3" /> | ||
| <text x="5" y="22" font-size="16px" fill="{{ text }}">{{ initials }}</text> | ||
| <ellipse ry="15" rx="15" cy="16" cx="16" fill="{{ background }}" stroke="{{ text_color }}" stroke-width="1" /> | ||
| <text x="50%" y="50%" dominant-baseline="central" text-anchor="middle" font-size="12px" fill="{{ text_color }}"> |
There was a problem hiding this comment.
You still should have fallback to text here if text_color is not set.
| @@ -1,4 +1,6 @@ | |||
| <symbol id="profile_image" viewBox="0 0 32 32" xmlns="http://www.w3.org/2000/svg"> | |||
| <ellipse ry="15" rx="15" cy="16" cx="16" fill="{{ background }}" stroke="#000000" stroke-width="3" /> | |||
| <text x="5" y="22" font-size="16px" fill="{{ text }}">{{ initials }}</text> | |||
| <ellipse ry="15" rx="15" cy="16" cx="16" fill="{{ background }}" stroke="{{ text_color }}" stroke-width="1" /> | |||
There was a problem hiding this comment.
Maybe we should not make that same mistake twice and use different variable name for stroke color as it is not text related, right?
ViniTou
approved these changes
Jun 27, 2022
Nattfarinn
approved these changes
Jun 27, 2022
Nattfarinn
approved these changes
Jun 27, 2022
GrabowskiM
approved these changes
Jun 27, 2022
|
Merged up:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.